@sainak the changes are done please review it again

https://github.com/coronasafe/care/pull/1531#issuecomment-1697511124

@sainak fixed conflicts

https://github.com/coronasafe/care/pull/1531#issuecomment-1697164848

@sainak please review

https://github.com/coronasafe/care/pull/1531#issuecomment-1685251400

@sainak Hi! Could you please approve the test run on this.

https://github.com/coronasafe/care/pull/1477#issuecomment-1664533658

@sainak test cases passing now.

https://github.com/coronasafe/care/pull/1455#issuecomment-1655545146

@sainak merged and fixed test cases

https://github.com/coronasafe/care/pull/1427#issuecomment-1655455265

@Bhavik-ag there is already a serializer field that has validations built in you should use that instead of calling it directly. `ExternalIdSerializerField`

https://github.com/coronasafe/care/pull/1445#issuecomment-1629043142

Could you elaborate maybe I can see this issue in my free time.

https://github.com/coronasafe/care/issues/1411#issuecomment-1623283551

What fields need to be overriden?

https://github.com/coronasafe/care/issues/1434#issuecomment-1621693097

@sainak yep fixed it

https://github.com/coronasafe/care/pull/1427#issuecomment-1621488429

@sainak done please check

https://github.com/coronasafe/care/pull/1427#issuecomment-1621383503

@sainak I don't think there exists a file named AssetDetail.tsx

https://github.com/coronasafe/care/pull/1427#issuecomment-1621181402

@vigneshhari Aaahhhhhh... makes sense, Thank You! Yep will do, could you please assign the issue to me.

https://github.com/coronasafe/care/issues/1339#issuecomment-1586132297

@sainak @nikhilagastya This is what I have gotten from my reasearch... First query comes from ConsultationBedSerializer -> BedSerializer (bed_object) -> AssetLocationSerializer (location_object) Second query comes from ConsultationBedSerializer -> ExternalIdSerializerField(consultation) -> queryset (attr) -> PatientConsultation.objects.all() Third query is always called because of the property in Bed Model in ./facility/models/bed.py @property def is_occupied(self) -> bool: return ConsultationBed.objects.filter(bed=self, end_date__isnull=True).exists() I evaluated it by making a custom middleware and wrapping the request/response in that ``` class SQLLoggingMiddleware: def __init__(self, get_response): self.get_response = get_response def __call__(self, request): response = self.get_response(request) sql_queries = connection.queries for query in sql_queries: logger.info(f"SQL Query: {query['sql']} - Time: {query['time']}") reset_queries() return response ``` Did some backtracking and logging got where they came from. I don't really see any optimisation can be done here, as they are coming from Serializer fields. Should we try passing the queryset from the view to Serializer?

https://github.com/coronasafe/care/issues/1339#issuecomment-1585224689

It needs to be wrapped in try catch to properly handle the error... But I would it would not be as easy to just wrap the code with try catch... the validation would go in another file, right?

https://github.com/coronasafe/care/issues/1348#issuecomment-1580953366

@rithviknishad Hi! Sir, I have successfully set up the working environment. To better analyse the joins I was looking forward to use the django_debug_toolbar, it seems to be already present in the settings. Could you guide me as how I would be able to get it running?

https://github.com/coronasafe/care_fe/issues/5492#issuecomment-1567457492