> @ProCode2 can you handle this issue ([coronasafe/care_fe#7000 (comment)](https://github.com/coronasafe/care_fe/pull/7000#issuecomment-1895353628)) also in this pr. > > To replicate the issue, In the front end, > > 1. Go to a patient consultation dashboard > 2. Link an Abha number > 3. Go to another patient's consultation dashboard > 4. Link the same Abha number again > > That will trigger the error you see in the comment mentioned. > > Have a conditional check if the Abha number already exists before creating the Abha number, and return a response with a neat error message. @khavinshankar by testing on https://care.ohc.network I traced it down to this function thats returning the error: This creates a ABHA object if not exists and then adds ABHA details to patient. Since `create_abha` is only creating the abha object if it does not exist it should be the `add_abha_details_to_patient` thats throwing error? So we need to not add abha details to a patient if that abha details is already linked with another patient? Do I understand this correctly? ```python def confirm_with_mobile_otp(self, request): data = request.data if ratelimit(request, "confirm_with_mobile_otp", [data["txnId"]]): raise CaptchaRequiredException( detail={"status": 429, "detail": "Too Many Requests Provide Captcha"}, code=status.HTTP_429_TOO_MANY_REQUESTS, ) serializer = VerifyOtpRequestPayloadSerializer(data=data) serializer.is_valid(raise_exception=True) response = HealthIdGateway().confirm_with_mobile_otp(data) abha_profile = HealthIdGateway().get_profile(response) # have a serializer to verify data of abha_profile abha_object = self.create_abha( abha_profile, { "access_token": response["token"], "refresh_token": response["refreshToken"], "txn_id": data["txnId"], }, ) if "patientId" in data: patient_id = data.pop("patientId") allowed_patients = get_patient_queryset(request.user) patient_obj = allowed_patients.filter(external_id=patient_id).first() if not patient_obj: raise ValidationError({"patient": "Not Found"}) if not self.add_abha_details_to_patient( abha_object, patient_obj, ): return Response( {"message": "Failed to add abha Number to the patient"}, status=status.HTTP_400_BAD_REQUEST, ) return Response( {"id": abha_object.external_id, "abha_profile": abha_profile}, status=status.HTTP_200_OK, ) ```

https://github.com/coronasafe/care/pull/1821#issuecomment-1898239678

Can I take this up?

https://github.com/coronasafe/ayushma_fe/issues/168#issuecomment-1895901816

@khavinshankar Can you take a look at #1821 and see if it looks good?

https://github.com/coronasafe/care/issues/1815#issuecomment-1890678658

Can I take this up? So as I understand the issue, We have to log the error response instead of sending them as response in places like these in the abdm API?: ```python try: AbdmGateway().init(data["resp"]["requestId"]) except Exception as e: return Response({"error": str(e)}, status=status.HTTP_400_BAD_REQUEST) ``` #### Questions: - What should be sent instead of the `e` object to the client instead? - This is how we should log instead right? ```python logger = logging.getLogger(__nane__) def post(self, request, *args, **kwargs): data = request.data try: AbdmGateway().init(data["resp"]["requestId"]) except Exception as e: logger.warning(f"Error while initialising ABDM Gateway: {e}", exc_info=True) return Response({ "error": "Something went wrong." }, status=status.HTTP_400_BAD_REQUEST) return Response({}, status=status.HTTP_202_ACCEPTED) ```

https://github.com/coronasafe/care/issues/1815#issuecomment-1886807281